mb_str_pad is an impure function#4849
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Feb 2, 2026
Merged
Conversation
ondrejmirtes
requested changes
Feb 2, 2026
| 'mb_scrub' => ['hasSideEffects' => false], | ||
| 'mb_split' => ['hasSideEffects' => false], | ||
| 'mb_str_pad' => ['hasSideEffects' => false], | ||
| 'mb_str_pad' => ['hasSideEffects' => true], |
Member
There was a problem hiding this comment.
What side effect does this function have?
Contributor
Author
There was a problem hiding this comment.
mb_str_pad(
string $string,
int $length,
string $pad_string = " ",
int $pad_type = STR_PAD_RIGHT,
?string $encoding = null
): string
If $encoding is null then the internal encoding is used, which can be changed by mb_internal_encoding(). This is not a side effect but means it's not entirely a pure function?
Member
There was a problem hiding this comment.
Alright, good enough :) Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning for this change is in JetBrains/phpstorm-stubs#1793 - I think this is the correct change to make on the PHPStan side.
Helps #4845 and in turn phpstan/phpstan#14041